Page MenuHomePhabricator

Fix improper selection of the chunk engine as a writable engine
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:30 PM.
Tags
None
Referenced Files
F13169667: D12110.diff
Tue, May 7, 8:32 AM
F13164842: D12110.diff
Tue, May 7, 4:53 AM
Unknown Object (File)
Fri, May 3, 8:32 AM
Unknown Object (File)
Thu, Apr 25, 2:23 AM
Unknown Object (File)
Sun, Apr 14, 5:01 AM
Unknown Object (File)
Thu, Apr 11, 8:05 AM
Unknown Object (File)
Apr 2 2024, 1:15 AM
Unknown Object (File)
Mar 29 2024, 12:29 PM
Subscribers

Details

Summary

Fixes T7621. The engine selection code started out making sense, but didn't make as much sense by the time I was done with it.

Specifically, from the vanilla file upload, we may incorrectly try to write directly to the chunk storage engine. This is incorrect, and produces a confusing/bad error.

Make chunk storage engines explicit and don't try to do single-file one-shot writes to them.

Test Plan
  • Tried to upload a large file with vanilla uploader, got better error message.
  • Uploaded small and large files with drag and drop.
  • Viewed FilesHelp/Options.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix improper selection of the chunk engine as a writable engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:31 AM
This revision was automatically updated to reflect the committed changes.