Page MenuHomePhabricator

Support resuming JS uploads of chunked files
ClosedPublic

Authored by epriestley on Mar 13 2015, 7:28 PM.
Tags
None
Referenced Files
F14377101: D12070.diff
Sat, Dec 21, 12:50 AM
Unknown Object (File)
Thu, Dec 19, 8:18 AM
Unknown Object (File)
Sat, Dec 14, 7:23 PM
Unknown Object (File)
Fri, Dec 13, 8:56 PM
Unknown Object (File)
Wed, Dec 11, 7:14 PM
Unknown Object (File)
Thu, Dec 5, 5:15 PM
Unknown Object (File)
Wed, Dec 4, 2:19 PM
Unknown Object (File)
Mon, Dec 2, 9:11 AM

Details

Summary

Ref T7149. We can't compute hashes of large files efficiently, but we can resume uploads by the same author, with the same name and file size, which are only partially completed. This seems like a reasonable heuristic that is unlikely to ever misfire, even if it's a little magical.

Test Plan
  • Forced chunking on.
  • Started uploading a chunked file.
  • Closed the browser window.
  • Dropped it into a new window.
  • Upload resumed (!!!)
  • Did this again.
  • Downloaded the final file, which successfully reconstructed the original file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support resuming JS uploads of chunked files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 10:30 PM
This revision was automatically updated to reflect the committed changes.