This adds a parameter for time only on Conpherence Transactions, although grepping around, Conpherence might be the only user of this View at this point. Since we have the date markers separately, we can use just the timestamp for a cleaner feel. Also updated a bit of the spacing and colors to match Conpherence Full. Ref T7531
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T7531: Polish for Conpherence Durable Column
- Commits
- Restricted Diffusion Commit
rPf77c5c514b5d: Show shorter time in Conpherence, revisit spacing/colors
A lot of Photoshop, and different types of chats.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- durable-timestamps
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4853 Build 4870: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
The case where the timestamp ends up on its own line ("11:26 PM") feels a little odd, but I don't think we have a clean way to deal with that. Possibly we could omit timestamps for metadata transactions in the column.
Comment Actions
Well if this View is really only used for Conpherence, we can gut it and save CSS, and customize the displays better.
| src/applications/conpherence/storage/ConpherenceTransaction.php | ||
|---|---|---|
| 58–69 | These should be "thread", or we should pick another noun, for consistency with "task", "revision", "commit", etc. (not "renamed this Maniphest ..."). | |
Comment Actions
What do you think about "Rooms". I hate to borrow the term from Slack, but we already call the product "Conpherence"
Comment Actions
I think there's a reasonable chance that we end up distinguishing between "threads" and "rooms" with some top-level property (e.g., join/membership rules?). If we do, using "thread" everywhere for now and then using "room" later when we introduce rooms might make sense.
I slightly prefer "thread" if we don't introduce rooms. Having large threads feels more natural to me than small rooms. For instance, I would find it odd if I sent you a private message and the first transaction was something like "epriestley added chad to the room.", whereas "epriestley added chad to the thread." feels fine even if the thread has 100 users.
But I don't really care that much.
Comment Actions
I think it should be "thread", not "Thread", or we should go change all the other text in every other application to "Task", etc.