Differential D12049

Show shorter time in Conpherence, revisit spacing/colors
ClosedPublic
Actions

Authored by chad on Mar 12 2015, 5:51 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7531: Polish for Conpherence Durable Column

Commits

Restricted Diffusion Commit
rPf77c5c514b5d: Show shorter time in Conpherence, revisit spacing/colors

Summary

This adds a parameter for time only on Conpherence Transactions, although grepping around, Conpherence might be the only user of this View at this point. Since we have the date markers separately, we can use just the timestamp for a cleaner feel. Also updated a bit of the spacing and colors to match Conpherence Full. Ref T7531

Test Plan

A lot of Photoshop, and different types of chats.

Screen_Shot_2015-03-12_at_10.26.49_AM.png (982×620 px, 106 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29003.Mar 12 2015, 5:51 PM

chad retitled this revision from to Show shorter time in Conpherence, revisit spacing/colors.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7531: Polish for Conpherence Durable Column.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 12 2015, 5:51 PM

chad edited the test plan for this revision. (Show Details)Mar 12 2015, 5:55 PM

The case where the timestamp ends up on its own line ("11:26 PM") feels a little odd, but I don't think we have a clean way to deal with that. Possibly we could omit timestamps for metadata transactions in the column.

Well if this View is really only used for Conpherence, we can gut it and save CSS, and customize the displays better.

epriestley accepted this revision.Mar 12 2015, 6:14 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/conpherence/storage/ConpherenceTransaction.php
58–69	These should be "thread", or we should pick another noun, for consistency with "task", "revision", "commit", etc. (not "renamed this Maniphest ...").

This revision is now accepted and ready to land.Mar 12 2015, 6:14 PM

What do you think about "Rooms". I hate to borrow the term from Slack, but we already call the product "Conpherence"

change to Thread

Closed by commit rPf77c5c514b5d: Show shorter time in Conpherence, revisit spacing/colors (authored by chad, committed by chad). · Explain WhyMar 12 2015, 6:21 PM

This revision was automatically updated to reflect the committed changes.

I think there's a reasonable chance that we end up distinguishing between "threads" and "rooms" with some top-level property (e.g., join/membership rules?). If we do, using "thread" everywhere for now and then using "room" later when we introduce rooms might make sense.

I slightly prefer "thread" if we don't introduce rooms. Having large threads feels more natural to me than small rooms. For instance, I would find it odd if I sent you a private message and the first transaction was something like "epriestley added chad to the room.", whereas "epriestley added chad to the thread." feels fine even if the thread has 100 users.

But I don't really care that much.