Page MenuHomePhabricator

Further improve line grouping in unified views
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:11 AM.
Tags
None
Referenced Files
F13284789: D11994.diff
Mon, Jun 3, 9:22 AM
F13278687: D11994.id28881.diff
Sat, Jun 1, 2:35 AM
F13278653: D11994.diff
Sat, Jun 1, 1:35 AM
F13269853: D11994.diff
Wed, May 29, 7:57 AM
F13258692: D11994.id28881.diff
Sun, May 26, 11:57 AM
F13241979: D11994.diff
Thu, May 23, 1:15 AM
F13225694: D11994.id28893.diff
Sun, May 19, 4:49 PM
F13223322: D11994.diff
Sun, May 19, 4:29 AM
Subscribers

Details

Summary

Ref T2009. This tweaks things a bit more to improve consecuitive groups of added and removed lines.

Generally, it gives us "old, old, old, new, new, new" intead of "old, new, old, new, old, new".

Feelin' real good about having unit tests for this stuff.

Test Plan

Unit tests, looked at diffs in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Further improve line grouping in unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Fix lint and tests, trailing whitespace removal threw a wrench into things.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 5:36 PM
This revision was automatically updated to reflect the committed changes.