Page MenuHomePhabricator

Further improve line grouping in unified views
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:53 PM
Unknown Object (File)
Sat, Nov 23, 12:29 AM
Unknown Object (File)
Fri, Nov 22, 7:34 PM
Unknown Object (File)
Oct 23 2024, 10:27 PM
Unknown Object (File)
Oct 20 2024, 1:10 PM
Unknown Object (File)
Oct 20 2024, 4:25 AM
Unknown Object (File)
Oct 18 2024, 7:57 AM
Unknown Object (File)
Oct 17 2024, 6:00 AM
Subscribers

Details

Summary

Ref T2009. This tweaks things a bit more to improve consecuitive groups of added and removed lines.

Generally, it gives us "old, old, old, new, new, new" intead of "old, new, old, new, old, new".

Feelin' real good about having unit tests for this stuff.

Test Plan

Unit tests, looked at diffs in web UI.

Diff Detail

Repository
rP Phabricator
Branch
uni15
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 4780
Build 4796: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
50 msDifferentialParseRenderTestCase::testParseRender

Event Timeline

epriestley retitled this revision from to Further improve line grouping in unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Fix lint and tests, trailing whitespace removal threw a wrench into things.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 5:36 PM
This revision was automatically updated to reflect the committed changes.