Page MenuHomePhabricator

Further improve line grouping in unified views
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:11 AM.
Tags
None
Referenced Files
F20841599: D11994.id.diff
Thu, Jun 25, 3:56 PM
Unknown Object (File)
Apr 21 2026, 11:24 PM
Unknown Object (File)
Mar 28 2026, 10:55 PM
Unknown Object (File)
Mar 11 2026, 9:10 AM
Unknown Object (File)
Mar 9 2026, 9:23 AM
Unknown Object (File)
Mar 5 2026, 4:21 PM
Unknown Object (File)
Mar 5 2026, 2:20 PM
Unknown Object (File)
Mar 5 2026, 5:53 AM
Subscribers

Details

Summary

Ref T2009. This tweaks things a bit more to improve consecuitive groups of added and removed lines.

Generally, it gives us "old, old, old, new, new, new" intead of "old, new, old, new, old, new".

Feelin' real good about having unit tests for this stuff.

Test Plan

Unit tests, looked at diffs in web UI.

Diff Detail

Repository
rP Phabricator
Branch
uni15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4781
Build 4797: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Further improve line grouping in unified views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Fix lint and tests, trailing whitespace removal threw a wrench into things.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 5:36 PM
This revision was automatically updated to reflect the committed changes.