Page MenuHomePhabricator
Differential D11935

Make it easier to add payment methods for subscription autopay
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 8:47 PM.
Tags
None
Referenced Files
F13232831: D11935.id28751.diff
Tue, May 21, 1:30 AM
F13232829: D11935.id28749.diff
Tue, May 21, 1:30 AM
F13232013: D11935.id.diff
Tue, May 21, 12:57 AM
F13231813: D11935.diff
Tue, May 21, 12:47 AM
F13213037: D11935.id28749.diff
Fri, May 17, 7:18 AM
Unknown Object (File)
Tue, May 7, 4:57 PM
Unknown Object (File)
Apr 28 2024, 7:43 AM
Unknown Object (File)
Apr 26 2024, 3:16 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6308: Make Fund/Phortune UI look more "professional" and less "scammy"
T7424: No "Add Payment Method" on Phortune Subscription autopay workflow
Commits
Restricted Diffusion Commit
rPb170d1c15f7d: Make it easier to add payment methods for subscription autopay
Summary

Fixes T7424. Ref T6308.

Currently, there's no option to just add a card directly from the autopay UI. Add a button so this works.

Also, chip away at T6308 a bit. This isn't perfect but looks a little less out of place.

Test Plan

Screen_Shot_2015-03-02_at_12.47.21_PM.png (1×1 px, 104 KB)

  • Added a payment method, then set it as autopay.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28749.Mar 2 2015, 8:47 PM
epriestley retitled this revision from to Make it easier to add payment methods for subscription autopay.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7424: No "Add Payment Method" on Phortune Subscription autopay workflow, T6308: Make Fund/Phortune UI look more "professional" and less "scammy".
Herald added a reviewer: chad. · View Herald TranscriptMar 2 2015, 8:47 PM
Herald added a subscriber: epriestley. · View Herald Transcript
btrahan accepted this revision.Mar 2 2015, 8:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 8:58 PM
Closed by commit rPb170d1c15f7d: Make it easier to add payment methods for subscription autopay (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
11 lines
src/
applications/
phortune/
controller/
51 lines
17 lines
provider/
2 lines
2 lines
view/
71 lines
view/
form/
control/
11 lines
webroot/
rsrc/
css/
application/
phortune/
5 lines
phui/
4 lines
image/

Diff 28751

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phortune/controller/PhortunePaymentMethodCreateController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneSubscriptionEditController.php

Loading...
View Options

src/applications/phortune/provider/PhortuneStripePaymentProvider.php

Loading...
View Options

src/applications/phortune/provider/PhortuneTestPaymentProvider.php

Loading...
View Options

src/applications/phortune/view/PhortuneCreditCardForm.php

Loading...
View Options

src/view/form/control/AphrontFormControl.php

Loading...
View Options

webroot/rsrc/css/application/phortune/phortune-credit-card-form.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/image/credit_cards.png

Loading...
Phabricator · Built by Phacility