Page MenuHomePhabricator
Differential D11914

Minor change to suppress linter warning
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 11:12 PM.
Tags
None
Referenced Files
F14026806: D11914.diff
Fri, Nov 8, 2:33 AM
F14007641: D11914.diff
Tue, Oct 29, 9:20 AM
F13981385: D11914.id29525.diff
Sat, Oct 19, 4:12 PM
F13981384: D11914.id28702.diff
Sat, Oct 19, 4:12 PM
F13967227: D11914.id28702.diff
Wed, Oct 16, 12:23 PM
Unknown Object (File)
Sep 21 2024, 10:49 PM
Unknown Object (File)
Sep 21 2024, 10:49 PM
Unknown Object (File)
Sep 21 2024, 10:49 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP48569f3629b2: Minor change to suppress linter warning
Summary

Explicitly declare the delimiter for preg_quote.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4685
Build 4699: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28702.Feb 28 2015, 11:12 PM
joshuaspence retitled this revision from to Minor change to suppress linter warning.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 11:12 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley added inline comments.Feb 28 2015, 11:37 PM
src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php
195

This one contains an unquoted # literal in the regexp, so I'd expect it to not work?

epriestley requested changes to this revision.Mar 22 2015, 6:59 PM
epriestley edited edge metadata.

(Just pushing back into your queue.)

This revision now requires changes to proceed.Mar 22 2015, 6:59 PM
joshuaspence updated this revision to Diff 29525.Apr 5 2015, 10:43 PM
joshuaspence edited edge metadata.

Fix delimiter

joshuaspence marked an inline comment as done.Apr 5 2015, 10:44 PM
epriestley accepted this revision.Apr 6 2015, 1:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:31 PM
Closed by commit rP48569f3629b2: Minor change to suppress linter warning (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 6 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
console/
controller/
2 lines
infrastructure/
markup/
rule/
8 lines

Diff 28702

View Options

src/applications/console/controller/DarkConsoleDataController.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php

Loading...
Phabricator · Built by Phacility