Rewrite this expression so that the second parameter to qsprintf is a scalar.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPca042df6deac: Minor change to suppress linter warning
arc lint
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4684 Build 4698: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Another thought that I had is to write an evaluatesToScalar() method for XHPASTNode, which is likely a better approach.
Comment Actions
I think this is preferable and clearer, even if we could reduce ternary expressions in the AST.