Page MenuHomePhabricator
Differential D11913

Minor change to suppress linter warning
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 11:12 PM.
Tags
None
Referenced Files
F15738374: D11913.id.diff
Thu, May 29, 6:41 PM
Unknown Object (File)
Wed, May 28, 11:19 AM
Unknown Object (File)
Wed, May 21, 3:59 AM
Unknown Object (File)
Sat, May 10, 4:34 AM
Unknown Object (File)
Apr 26 2025, 5:20 PM
Unknown Object (File)
Apr 21 2025, 7:44 PM
Unknown Object (File)
Apr 21 2025, 11:04 AM
Unknown Object (File)
Apr 17 2025, 4:34 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPca042df6deac: Minor change to suppress linter warning
Summary

Rewrite this expression so that the second parameter to qsprintf is a scalar.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28701.Feb 28 2015, 11:12 PM
joshuaspence retitled this revision from to Minor change to suppress linter warning.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 11:12 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 28 2015, 11:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 28 2015, 11:36 PM
joshuaspence added a comment.Mar 1 2015, 8:21 PM

Another thought that I had is to write an evaluatesToScalar() method for XHPASTNode, which is likely a better approach.

epriestley added a comment.Mar 1 2015, 8:26 PM

I think this is preferable and clearer, even if we could reduce ternary expressions in the AST.

joshuaspence added a comment.Mar 1 2015, 9:14 PM
In D11913#116247, @epriestley wrote:

I think this is preferable and clearer, even if we could reduce ternary expressions in the AST.

This meaning this diff?

epriestley added a comment.Mar 1 2015, 9:32 PM

Yeah.

Closed by commit rPca042df6deac: Minor change to suppress linter warning (authored by joshuaspence, committed by joshuaspence). · Explain WhyMar 17 2015, 11:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
query/
10 lines

Diff 29094

View Options

src/applications/feed/query/PhabricatorFeedQuery.php

Loading...
Phabricator · Built by Phacility