Page MenuHomePhabricator
Differential D11900

Move ui.custom_header to UI Config
ClosedPublic
Actions

Authored by chad on Feb 27 2015, 1:03 AM.
Tags
None
Referenced Files
F13175380: D11900.diff
Wed, May 8, 4:52 AM
Unknown Object (File)
Tue, May 7, 4:53 AM
Unknown Object (File)
Fri, May 3, 10:17 PM
Unknown Object (File)
Fri, May 3, 2:15 AM
Unknown Object (File)
Thu, May 2, 6:25 PM
Unknown Object (File)
Mon, Apr 29, 11:50 AM
Unknown Object (File)
Mon, Apr 29, 5:01 AM
Unknown Object (File)
Sun, Apr 28, 4:08 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T4214: Allow installs to change or supplement the "Phabricator" icon
Commits
Restricted Diffusion Commit
rP2476cfba3d9e: Move ui.custom_header to UI Config
Summary

Moves the setting from Core to UI, also adds a link to the task for further instructions.

Test Plan

Load up config in sandbox, see new instructions.

Diff Detail

Repository
rP Phabricator
Branch
ui-header-config
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4664
Build 4678: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28664.Feb 27 2015, 1:03 AM
chad retitled this revision from to Move ui.custom_header to UI Config.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 27 2015, 1:03 AM
chad added inline comments.Feb 27 2015, 1:04 AM
src/applications/config/option/PhabricatorUIConfigOptions.php
95

I don't know how to correctly write this.

chad added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Feb 27 2015, 1:04 AM
epriestley edited edge metadata.Feb 27 2015, 1:05 AM

That looks correct, does it not work?

chad updated this revision to Diff 28665.Feb 27 2015, 1:12 AM
chad edited edge metadata.
  • Fix pht
chad added a comment.Feb 27 2015, 1:12 AM

I had a ) in the wrong place, it's fine now.

epriestley accepted this revision.Feb 27 2015, 1:18 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2015, 1:18 AM
Closed by commit rP2476cfba3d9e: Move ui.custom_header to UI Config (authored by chad, committed by chad). · Explain WhyFeb 27 2015, 1:36 AM
This revision was automatically updated to reflect the committed changes.
• wasimsikder removed a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:00 AM
avivey added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:43 AM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
option/
23 lines
28 lines

Diff 28664

View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...
Phabricator · Built by Phacility