Page MenuHomePhabricator
Differential D11674

Remove unused PhabricatorFeedStory subclasses
ClosedPublic
Actions

Authored by joshuaspence on Feb 4 2015, 9:20 AM.
Tags
None
Referenced Files
F14059701: D11674.id28287.diff
Sun, Nov 17, 9:09 PM
F14059700: D11674.id28093.diff
Sun, Nov 17, 9:08 PM
F14059699: D11674.id29526.diff
Sun, Nov 17, 9:08 PM
F14059698: D11674.id28094.diff
Sun, Nov 17, 9:08 PM
F14059696: D11674.id31086.diff
Sun, Nov 17, 9:08 PM
F14010114: D11674.id31086.diff
Thu, Oct 31, 5:08 AM
F14008493: D11674.diff
Tue, Oct 29, 10:45 PM
F14005503: D11674.id28287.diff
Sun, Oct 27, 2:12 PM
View All Files
Subscribers
btrahan
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rPb5bf8e998d53: Remove unused PhabricatorFeedStory subclasses
Summary

Remove a bunch of unused PhabricatorFeedStory subclasses.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4320
Build 4333: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28093.Feb 4 2015, 9:20 AM
joshuaspence retitled this revision from to Rename `PhabricatorFeedStory` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 4 2015, 9:20 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 28094.Feb 4 2015, 9:24 AM
joshuaspence edited edge metadata.

Found another

epriestley added a comment.Feb 9 2015, 2:40 PM

These are used in the storyType column of phabricator_feed.feed_storydata, so I'd expect that to likely need a migration.

joshuaspence updated this revision to Diff 28287.Feb 11 2015, 7:42 AM

Add migration

joshuaspence updated this object.Feb 11 2015, 7:42 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence updated this revision to Diff 29526.Apr 6 2015, 10:05 AM

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptApr 6 2015, 10:05 AM
epriestley edited edge metadata.Apr 6 2015, 1:33 PM

Thinking about this, I suspect most of these are never published anymore and they can simply be removed. Are there actually callsites for this stuff?

joshuaspence added a comment.Apr 6 2015, 10:16 PM

Hmm, it seems that you are correct (I grepped for a few of the class names). Why is that?

btrahan added a subscriber: btrahan.Apr 6 2015, 10:17 PM

iiirc, the move to transactions obsoleted application-specific feed stories.

joshuaspence updated this revision to Diff 31086.May 19 2015, 8:36 AM
joshuaspence edited edge metadata.

Remove unused classes

joshuaspence retitled this revision from Rename `PhabricatorFeedStory` subclasses to Remove unused PhabricatorFeedStory subclasses.May 19 2015, 8:36 AM
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.May 19 2015, 12:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 12:58 PM
Closed by commit rPb5bf8e998d53: Remove unused PhabricatorFeedStory subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28094

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/feed/story/PhabricatorAggregateFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorAuditFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorCommitFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorDifferentialAggregateFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorDifferentialFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryAggregate.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryAudit.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryCommit.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryDifferential.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryDifferentialAggregate.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryManiphestAggregate.php

Loading...
View Options

src/applications/feed/story/PhabricatorFeedStoryPhriction.php

Loading...
View Options

src/applications/feed/story/PhabricatorManiphestAggregateFeedStory.php

Loading...
View Options

src/applications/feed/story/PhabricatorPhrictionFeedStory.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationTestController.php

Loading...
View Options

src/applications/notification/feed/PhabricatorAdHocNotificationFeedStory.php

Loading...
View Options

src/applications/notification/feed/PhabricatorNotificationAdHocFeedStory.php

Loading...
Phabricator · Built by Phacility