Page MenuHomePhabricator

Move XHPAST build script to PHP
ClosedPublic

Authored by joshuaspence on Feb 2 2015, 9:22 PM.
Tags
None
Referenced Files
F14868455: D11629.id28053.diff
Sat, Feb 8, 2:14 AM
F14868454: D11629.id28012.diff
Sat, Feb 8, 2:13 AM
F14868453: D11629.id27986.diff
Sat, Feb 8, 2:13 AM
F14868452: D11629.id.diff
Sat, Feb 8, 2:13 AM
Unknown Object (File)
Thu, Feb 6, 10:13 AM
Unknown Object (File)
Wed, Jan 29, 10:59 PM
Unknown Object (File)
Tue, Jan 28, 1:46 AM
Unknown Object (File)
Thu, Jan 23, 11:22 PM
Subscribers

Details

Summary

Currently, building XHPAST from within PHP involves running PhutilXHPASTBinary::build(), which executes the ./scripts/build_xhpast.sh script, which then calls make. Instead, we can bypass ./scripts/build_xhpast.sh and call make directly from PhutilXHPASTBinary::build(). This feels a lot cleaner.

I have retained the ./scripts/build_xhpast.sh script, although it is really a PHP file now. I was considering renaming it to build_xhpast.php, but decided to leave it as is for backwards compatibility.

Test Plan
> ./scripts/build_xhpast.sh 
Build successful!

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4254
Build 4267: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Move XHPAST build script to PHP.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Rename build_xhpast.php to build_xhpast.sh

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence updated this object.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 1:11 PM
This revision was automatically updated to reflect the committed changes.