Page MenuHomePhabricator
Differential D11629

Move XHPAST build script to PHP
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 9:22 PM.
Tags
None
Referenced Files
F17930438: D11629.diff
Wed, Jul 30, 6:02 PM
Unknown Object (File)
Jun 18 2025, 10:08 PM
Unknown Object (File)
Jun 16 2025, 10:50 PM
Unknown Object (File)
May 10 2025, 1:14 PM
Unknown Object (File)
May 6 2025, 9:57 AM
Unknown Object (File)
Apr 25 2025, 3:12 AM
Unknown Object (File)
Apr 23 2025, 6:40 AM
Unknown Object (File)
Apr 22 2025, 12:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUb2783c6314c2: Move XHPAST build script to PHP
Summary

Currently, building XHPAST from within PHP involves running PhutilXHPASTBinary::build(), which executes the ./scripts/build_xhpast.sh script, which then calls make. Instead, we can bypass ./scripts/build_xhpast.sh and call make directly from PhutilXHPASTBinary::build(). This feels a lot cleaner.

I have retained the ./scripts/build_xhpast.sh script, although it is really a PHP file now. I was considering renaming it to build_xhpast.php, but decided to leave it as is for backwards compatibility.

Test Plan
> ./scripts/build_xhpast.sh 
Build successful!

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27986.Feb 2 2015, 9:22 PM
joshuaspence retitled this revision from to Move XHPAST build script to PHP.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 9:22 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 28012.Feb 3 2015, 7:19 AM
joshuaspence edited edge metadata.

Rename build_xhpast.php to build_xhpast.sh

joshuaspence updated this object.Feb 3 2015, 7:23 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence updated this object.
joshuaspence updated this object.Feb 3 2015, 7:26 AM
epriestley accepted this revision.Feb 3 2015, 1:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 1:11 PM
Closed by commit rPHUb2783c6314c2: Move XHPAST build script to PHP (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 3 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
39 lines
src/
parser/
xhpast/
bin/
38 lines

Diff 28053

View Options

scripts/build_xhpast.sh

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
Phabricator · Built by Phacility