Page MenuHomePhabricator
Differential D11612

Use `PhutilXHPASTBinary` methods
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 10:12 AM.
Tags
None
Referenced Files
F14877155: D11612.id27974.diff
Sat, Feb 8, 6:27 PM
Unknown Object (File)
Sat, Feb 8, 2:12 AM
Unknown Object (File)
Sat, Feb 8, 2:12 AM
Unknown Object (File)
Sat, Feb 8, 2:12 AM
Unknown Object (File)
Thu, Jan 23, 11:18 PM
Unknown Object (File)
Thu, Jan 23, 11:18 PM
Unknown Object (File)
Thu, Jan 23, 11:18 PM
Unknown Object (File)
Sun, Jan 19, 1:14 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7982b23eb405: Use `PhutilXHPASTBinary` methods
Summary

Use PhutilXHPASTBinary methods instead of xhpast_parse functions. Depends on D11517.

Test Plan

N/A, this is a direct swap.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4232
Build 4245: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27947.Feb 2 2015, 10:12 AM
joshuaspence retitled this revision from to Use `PhutilXHPASTBinary` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11517: Create a PHP wrapper class for the XHPAST binary.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:12 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 2 2015, 1:55 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2015, 1:55 PM
joshuaspence updated this object.Feb 2 2015, 7:58 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
Closed by commit rP7982b23eb405: Use `PhutilXHPASTBinary` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a child revision: D11615: Remove `xhpast_parse` methods.Feb 2 2015, 8:00 PM

Revision Contents
Changeset List

PathSize
scripts/
symbols/
2 lines
src/
applications/
diviner/
atomizer/
2 lines
phpast/
controller/
2 lines
infrastructure/
internationalization/
management/
2 lines

Diff 27947

View Options

scripts/symbols/generate_php_symbols.php

Loading...
View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

Loading...
View Options

src/applications/phpast/controller/PhabricatorXHPASTViewRunController.php

Loading...
View Options

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php

Loading...
Phabricator · Built by Phacility