Page MenuHomePhabricator
Differential D11604

Change "any" to explicitly list revision control systems
ClosedPublic
Actions

Authored by joshuaspence on Feb 1 2015, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:23 PM
Unknown Object (File)
Sun, Dec 8, 12:52 PM
Unknown Object (File)
Thu, Dec 5, 8:12 PM
Unknown Object (File)
Mon, Dec 2, 8:01 PM
Unknown Object (File)
Mon, Nov 25, 8:42 PM
Unknown Object (File)
Mon, Nov 25, 1:31 PM
Unknown Object (File)
Mon, Nov 25, 11:13 AM
Unknown Object (File)
Nov 21 2024, 1:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC623df14ae50b: Change "any" to explicitly list revision control systems
Summary

Using array('any') to represent array('git', 'hg', 'svn') is a bit magical and leads to a lot of special-casing.

Test Plan

Verified that tab completion (ala ArcanistShellCompleteWorkflow) still worked.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4215
Build 4228: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27922.Feb 1 2015, 8:40 PM
joshuaspence retitled this revision from to Change "any" to explicitly list revision control systems.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 1 2015, 8:40 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence added a child revision: D11550: Explicitly check for supported VCS.Feb 1 2015, 8:41 PM
joshuaspence updated this object.Feb 1 2015, 8:44 PM
joshuaspence edited edge metadata.
joshuaspence edited the test plan for this revision. (Show Details)Feb 1 2015, 8:54 PM
epriestley accepted this revision.Feb 2 2015, 4:11 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2015, 4:11 AM
Closed by commit rARC623df14ae50b: Change "any" to explicitly list revision control systems (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27922

View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility