Add comments to XHPAST functions
ClosedPublic
Actions

Authored by joshuaspence on Jan 27 2015, 10:10 AM.

Tags

None

Referenced Files

	F13271465: D11519.diff
	Wed, May 29, 11:52 PM

	F13252270: D11519.diff
	Sat, May 25, 1:14 AM

	F13224876: D11519.id27721.diff
	Sun, May 19, 11:34 AM

	F13205349: D11519.diff
	Wed, May 15, 1:51 AM

	F13192935: D11519.id27721.diff
	Sun, May 12, 10:52 AM

	F13189544: D11519.diff
	Sat, May 11, 6:09 AM

	F13181403: D11519.id27699.diff
	Thu, May 9, 12:06 PM

	Unknown Object (File)
	Sun, May 5, 5:19 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU940ff183908f: Add comments to XHPAST functions

Summary

Add some docblock comments to various XHPAST functions.

Test Plan

Eyeball it.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4078
Build 4091: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27699.Jan 27 2015, 10:10 AM

joshuaspence retitled this revision from to Add comments to XHPAST functions.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2015, 10:10 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

(Also put the functions in alphabetical order)

epriestley accepted this revision.Jan 27 2015, 2:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2015, 2:06 PM

Closed by commit rPHU940ff183908f: Add comments to XHPAST functions (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 27 2015, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

xhpast_parse.php

56 lines

Diff 27699

View Options

src/parser/xhpast/bin/xhpast_parse.php

Add comments to XHPAST functionsClosedPublicActions