Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
F18914364: D11479.id.diff
Nov 9 2025, 6:50 AM
F18904809: D11479.diff
Nov 8 2025, 11:12 AM
F18854510: D11479.id.diff
Nov 1 2025, 12:20 AM
F18777098: D11479.id.diff
Oct 11 2025, 12:54 AM
F18768604: D11479.id27611.diff
Oct 8 2025, 4:26 AM
F18766625: D11479.id27611.diff
Oct 7 2025, 5:37 PM
F18765989: D11479.id27610.diff
Oct 7 2025, 2:18 PM
F18765843: D11479.id27610.diff
Oct 7 2025, 1:23 PM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Branch
T7021
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4018
Build 4031: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.