Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
F14055387: D11479.diff
Sat, Nov 16, 11:17 AM
F14041526: D11479.diff
Mon, Nov 11, 7:23 PM
F14028586: D11479.diff
Fri, Nov 8, 2:14 PM
F13980410: D11479.diff
Oct 19 2024, 10:28 AM
Unknown Object (File)
Sep 27 2024, 11:52 PM
Unknown Object (File)
Sep 27 2024, 11:50 PM
Unknown Object (File)
Sep 27 2024, 11:49 PM
Unknown Object (File)
Sep 27 2024, 11:47 PM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Branch
T7021
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4018
Build 4031: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.