Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits

Authored by btrahan on Jan 23 2015, 7:31 PM.
Referenced Files
F12199218: D11479.id27610.diff
Sat, Sep 30, 6:44 PM
F12177295: D11479.diff
Sun, Sep 10, 9:04 PM
F12169275: D11479.id27611.diff
Thu, Sep 7, 8:12 AM
F12165440: D11479.diff
Thu, Sep 7, 12:14 AM
F12161771: D11479.diff
Wed, Sep 6, 4:58 PM
F12141655: D11479.diff
Aug 29 2023, 10:28 PM
F12136360: D11479.id27610.diff
Aug 26 2023, 3:50 AM
Unknown Object (File)
Aug 16 2023, 6:19 PM



Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 4018
Build 4031: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.