Page MenuHomePhabricator

Audit - fix issue "showing older" on some commits
ClosedPublic

Authored by btrahan on Jan 23 2015, 7:31 PM.
Tags
None
Referenced Files
F13081401: D11479.id27610.diff
Wed, Apr 24, 6:29 PM
Unknown Object (File)
Thu, Apr 18, 8:37 AM
Unknown Object (File)
Thu, Apr 18, 7:46 AM
Unknown Object (File)
Wed, Apr 17, 12:41 AM
Unknown Object (File)
Tue, Apr 16, 5:12 AM
Unknown Object (File)
Mar 25 2024, 11:38 AM
Unknown Object (File)
Mar 25 2024, 11:38 AM
Unknown Object (File)
Mar 5 2024, 7:48 AM
Subscribers

Details

Summary

Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan

pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Audit - fix issue "showing older" on some commits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 23 2015, 7:31 PM
This revision was automatically updated to reflect the committed changes.