Paths

Table of Contentst

Differential D11470

Rename `DifferentialHunk` subclasses for consistency
ClosedPublic
Actions

Authored by joshuaspence on Jan 22 2015, 8:09 PM.

Tags

None

Referenced Files

	F15434846: D11470.diff
	Tue, Mar 25, 5:41 AM

	F15368393: D11470.diff
	Wed, Mar 12, 1:46 AM

	Unknown Object (File)
	Feb 26 2025, 4:49 AM

	Unknown Object (File)
	Feb 18 2025, 5:34 PM

	Unknown Object (File)
	Feb 18 2025, 5:33 PM

	Unknown Object (File)
	Feb 8 2025, 1:33 AM

	Unknown Object (File)
	Feb 8 2025, 1:33 AM

	Unknown Object (File)
	Feb 8 2025, 1:33 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5655: Standardize naming conventions

Commits

Restricted Diffusion Commit
rP25ee2d4508d8: Rename `DifferentialHunk` subclasses for consistency

Summary

Ref T5655.

Test Plan

arc lint

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 3989
Build 4002: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	32,287 ms	PhabricatorLibraryTestCase::testMethodVisibility
	988 ms	DifferentialChangesetParserTestCase::testDiffChangesets
	701 ms	DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParser
	546 ms	DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParserNormalization
	528 ms	DifferentialCustomFieldDependsOnParserTestCase::testParser
		View Full Test Results (1 Failed · 34 Passed)

Event Timeline

joshuaspence updated this revision to Diff 27567.Jan 22 2015, 8:09 PM

joshuaspence retitled this revision from to Rename `DifferentialHunk` subclasses for consistency.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5655: Standardize naming conventions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 22 2015, 8:09 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 22 2015, 8:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2015, 8:16 PM

Closed by commit rP25ee2d4508d8: Rename `DifferentialHunk` subclasses for consistency (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

differential/

management/

PhabricatorHunksManagementMigrateWorkflow.php

4 lines

parser/

__tests__/

DifferentialChangesetParserTestCase.php

4 lines

DifferentialHunkParserTestCase.php

2 lines

query/

DifferentialHunkQuery.php

4 lines

storage/

DifferentialChangeset.php

4 lines

DifferentialDiff.php

2 lines

DifferentialHunkLegacy.php

DifferentialHunkModern.php

	DifferentialLegacyHunk.php
	DifferentialHunkLegacy.php

2 lines

	DifferentialModernHunk.php
	DifferentialHunkModern.php

2 lines

__tests__/

DifferentialHunkTestCase.php

4 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

4 lines

Diff 27567

src/__phutil_library_map__.php

Loading...

src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php

Loading...

src/applications/differential/parser/tests/DifferentialChangesetParserTestCase.php

Loading...

src/applications/differential/parser/tests/DifferentialHunkParserTestCase.php

Loading...

src/applications/differential/query/DifferentialHunkQuery.php

Loading...

src/applications/differential/storage/DifferentialChangeset.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/differential/storage/DifferentialHunkLegacy.php

Loading...

src/applications/differential/storage/DifferentialHunkModern.php

Loading...

src/applications/differential/storage/DifferentialLegacyHunk.php

Loading...

src/applications/differential/storage/DifferentialModernHunk.php

Loading...

src/applications/differential/storage/tests/DifferentialHunkTestCase.php

Loading...

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...