Paths

Table of Contentst

Differential D11412

Fix visibility of `PhabricatorLiskDAO::establishLiveConnection` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:43 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP2f043b253012: Fix visibility of `PhabricatorLiskDAO::establishLiveConnection` method

Summary

Ref T6822.

Test Plan

grep. This method is only called from within LiskDAO::establishConnection().

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3873
Build 3885: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27403.Jan 15 2015, 12:43 PM

joshuaspence retitled this revision from to Fix visibility of `PhabricatorLiskDAO::establishLiveConnection` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:43 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 2:25 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 2:25 PM

Closed by commit rP2f043b253012: Fix visibility of `PhabricatorLiskDAO::establishLiveConnection` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 7:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

lisk/

PhabricatorLiskDAO.php

2 lines

Diff 27403

View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Fix visibility of `PhabricatorLiskDAO::establishLiveConnection` methodClosedPublicActions