Ref T6822.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6822: Fix methods which override other methods with the wrong visibility
- Commits
- Restricted Diffusion Commit
rP9f29af108bbb: Fix visibility of some `LiskDAO` methods
Ran unit tests.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3871 Build 3883: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php | ||
|---|---|---|
| 48–50 | Since this is on a dedicated test object anyway, and we're testing the test-behavior of the test object, maybe consider defining a public method which calls the protected method instead of bypassing access. On the other hand, that would make the test less pure. I'm not sure if the sanctity of the test or the sanctity of the visibility keyword is greater. O woe! | |
| src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php | ||
|---|---|---|
| 48–50 | I'm just going to leave this as is for now, mainly because I am not good at naming things. | |