Paths

Table of Contentst

Differential D11408

Fix visibility of the `PhutilOAuth1Future::getProxiedFuture()` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:33 PM.

Tags

None

Referenced Files

	F14913116: D11408.diff
	Wed, Feb 12, 2:22 AM

	Unknown Object (File)
	Mon, Feb 10, 4:07 AM

	Unknown Object (File)
	Sun, Feb 9, 1:05 PM

	Unknown Object (File)
	Sat, Feb 8, 1:12 AM

	Unknown Object (File)
	Sat, Feb 8, 1:12 AM

	Unknown Object (File)
	Sat, Feb 8, 1:12 AM

	Unknown Object (File)
	Fri, Feb 7, 9:53 AM

	Unknown Object (File)
	Tue, Feb 4, 1:51 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

rPHUc81e973f82ea: Fix visibility of the `PhutilOAuth1Future::getProxiedFuture()` method

Summary

Ref T6822.

Test Plan

grep

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3869
Build 3881: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27399.Jan 15 2015, 12:33 PM

joshuaspence retitled this revision from to Fix visibility of the `FutureProxy::getProxiedFuture()` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:33 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 2:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM

joshuaspence retitled this revision from Fix visibility of the `FutureProxy::getProxiedFuture()` method to Fix visibility of the `PhutilOAuth1Future::getProxiedFuture()` method.Jan 15 2015, 7:57 PM

joshuaspence edited edge metadata.

Closed by commit rPHUc81e973f82ea: Fix visibility of the `PhutilOAuth1Future::getProxiedFuture()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

future/

oauth/

PhutilOAuth1Future.php

2 lines

Diff 27399

src/future/oauth/PhutilOAuth1Future.php

Loading...