Page MenuHomePhabricator
Differential D11407

Fix visibility of `ConduitAPIMethod::execute` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:32 PM.
Tags
None
Referenced Files
F15498488: D11407.id27411.diff
Sun, Apr 13, 1:03 PM
F15493057: D11407.id27398.diff
Sat, Apr 12, 9:08 PM
F15492696: D11407.id.diff
Sat, Apr 12, 5:18 PM
F15490808: D11407.diff
Fri, Apr 11, 8:42 PM
F15434778: D11407.id27398.diff
Tue, Mar 25, 5:20 AM
F15428948: D11407.diff
Mar 23 2025, 11:39 PM
F15423383: D11407.id27411.diff
Mar 22 2025, 3:15 PM
F15419778: D11407.diff
Mar 21 2025, 8:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPa76b161c7ff0: Fix visibility of `ConduitAPIMethod::execute` methods
Summary

Ref T6822. These methods should be protected.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3868
Build 3880: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27398.Jan 15 2015, 12:32 PM
joshuaspence retitled this revision from to Fix visibility of `ConduitAPIMethod::execute` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:32 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 2:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM
joshuaspence updated this object.Jan 15 2015, 7:57 PM
joshuaspence edited edge metadata.
Closed by commit rPa76b161c7ff0: Fix visibility of `ConduitAPIMethod::execute` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
tokens/
conduit/
2 lines
2 lines
2 lines

Diff 27398

View Options

src/applications/tokens/conduit/TokenGiveConduitAPIMethod.php

Loading...
View Options

src/applications/tokens/conduit/TokenGivenConduitAPIMethod.php

Loading...
View Options

src/applications/tokens/conduit/TokenQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility