Page MenuHomePhabricator
Differential D11376

Fix various lint issues in rJX
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 8:27 PM.
Tags
None
Referenced Files
F15420963: D11376.id27329.diff
Fri, Mar 21, 7:36 PM
F15410475: D11376.diff
Wed, Mar 19, 7:27 AM
F15398172: D11376.id.diff
Sun, Mar 16, 11:39 PM
F15396079: D11376.diff
Sun, Mar 16, 11:42 AM
F15335493: D11376.diff
Sat, Mar 8, 3:55 PM
Unknown Object (File)
Feb 8 2025, 1:08 AM
Unknown Object (File)
Feb 8 2025, 1:08 AM
Unknown Object (File)
Feb 8 2025, 1:08 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6953: Don't exclude `/webroot/rsrc/externals/` from linting
Commits
Restricted Diffusion Commit
rPe768a633b751: Fix various lint issues in rJX
Summary

Ref T6953.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/externals/javelin/lib/Request.js:42W117JSHintW117
Warningwebroot/rsrc/externals/javelin/lib/Request.js:45W117JSHintW117
Warningwebroot/rsrc/externals/javelin/lib/Request.js:275W117JSHintW117
Unit
No Test Coverage
Build Status
Buildable 3824
Build 3836: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27326.Jan 13 2015, 8:27 PM
joshuaspence retitled this revision from to Fix variious lint issues in rJX.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6953: Don't exclude `/webroot/rsrc/externals/` from linting.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 8:27 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 8:29 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/externals/javelin/lib/Leader.js
222

oh nice

webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
405

also nice

This revision is now accepted and ready to land.Jan 13 2015, 8:29 PM
joshuaspence retitled this revision from Fix variious lint issues in rJX to Fix various lint issues in rJX.Jan 13 2015, 8:59 PM
joshuaspence edited edge metadata.
Closed by commit rPe768a633b751: Fix various lint issues in rJX (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
externals/
javelin/
core/
__tests__/
6 lines
2 lines
2 lines
2 lines
ext/
reactor/
core/
2 lines
2 lines
dom/
6 lines
view/
16 lines
2 lines
4 lines
__tests__/
4 lines
lib/
3 lines
8 lines
2 lines
4 lines
__tests__/
2 lines
2 lines
control/
tokenizer/
4 lines
typeahead/
8 lines
source/
2 lines

Diff 27326

View Options

webroot/rsrc/externals/javelin/core/__tests__/stratcom.js

Loading...
View Options

webroot/rsrc/externals/javelin/core/__tests__/util.js

Loading...
View Options

webroot/rsrc/externals/javelin/core/install.js

Loading...
View Options

webroot/rsrc/externals/javelin/core/util.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/reactor/core/ReactorNode.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/reactor/dom/RDOM.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/view/HTMLView.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/view/ViewInterpreter.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/view/ViewPlaceholder.js

Loading...
View Options

webroot/rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Leader.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Request.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Resource.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/WebSocket.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/__tests__/JSON.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/__tests__/URI.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadSource.js

Loading...
Phabricator · Built by Phacility