Just wondering what the rationale is for excluding webroot/rsrc/externals/ from linting? This directory isn't really an externals directory and appears to be actively developed on (for example, D11235).
Description
Description
Revisions and Commits
Revisions and Commits
| rP Phabricator | |||
| D11376 | rPe768a633b751 Fix various lint issues in rJX | ||
| D11375 | rPd0e4e960419e Lint the `webroot/rsrc/externals/javelin` directory | ||
Related Objects
Related Objects
- Mentioned Here
- D11235: Add JX.Leader: synchronization over localStorage
Event Timeline
Comment Actions
I think that at one point, it just had Raphael (a "real" external). Javelin should get linted. As an easy fix, we could exclude Raphael only.
Comment Actions
We haven't synchronized changes to rJX for a long time. No one is really using it outside of us and almost all the new stuff is advanced (JX.Leader, JX.Routable, JX.WebSocket) so it doesn't end up at the top of my priority list.
Comment Actions
I think there are more installs using Ponder than projects using Javelin, yes.
Javelin still seems to be in use in some form on m.facebook.com, but I'd guess it's heavily modified and/or years out of date.