javelin` directory
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 8:10 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6953: Don't exclude `/webroot/rsrc/externals/` from linting

Commits

Restricted Diffusion Commit
rPd0e4e960419e: Lint the `webroot/rsrc/externals/javelin` directory

Summary

Fixes T6953. As discussed, this directory should be linted.

Test Plan

Ran arc lint on a file in webroot/rsrc/externals/javelin and saw linter errors.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3823
Build 3835: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27325.Jan 13 2015, 8:10 PM

joshuaspence retitled this revision from to Lint the `webroot/rsrc/externals/javelin` directory.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6953: Don't exclude `/webroot/rsrc/externals/` from linting.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 8:10 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 13 2015, 8:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 13 2015, 8:10 PM

Closed by commit rPd0e4e960419e: Lint the `webroot/rsrc/externals/javelin` directory (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

.arclint

8 lines

Diff 27325

View Options

Lint the `webroot/rsrc/externals/javelin` directoryClosedPublicActions