Page MenuHomePhabricator
Differential D11367

Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 9:11 PM
Unknown Object (File)
Thu, Jan 23, 9:40 PM
Unknown Object (File)
Thu, Jan 23, 9:40 PM
Unknown Object (File)
Thu, Jan 23, 9:40 PM
Unknown Object (File)
Thu, Jan 23, 9:40 PM
Unknown Object (File)
Wed, Jan 22, 5:36 PM
Unknown Object (File)
Tue, Jan 21, 3:29 PM
Unknown Object (File)
Tue, Jan 21, 3:26 PM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP463d094f963b: Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses
Summary

Ref T6822.

Test Plan

grep for the following:

  • ->willFilterPage(
  • ->loadPage(
  • ->didFilterPage(
  • ->getReversePaging(
  • ->didFilterPage(
  • ->willExecute(
  • ->nextPage(

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27300.Jan 13 2015, 11:45 AM
joshuaspence retitled this revision from to Fix method visibility for polciy query.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:45 AM
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 1:36 PM
epriestley edited edge metadata.

Nice, this one's a big one since misusing this API violates policies.

This revision is now accepted and ready to land.Jan 13 2015, 1:36 PM
joshuaspence retitled this revision from Fix method visibility for polciy query to Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses.Jan 13 2015, 7:55 PM
joshuaspence updated this object.
joshuaspence edited edge metadata.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Closed by commit rP463d094f963b: Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
query/
4 lines
chatlog/
query/
2 lines
conduit/
query/
2 lines
2 lines
2 lines
config/
query/
2 lines
daemon/
query/
4 lines
differential/
query/
8 lines
4 lines
8 lines
4 lines
diffusion/
query/
2 lines
doorkeeper/
query/
2 lines
drydock/
query/
2 lines
4 lines
4 lines
2 lines
flag/
query/
4 lines
herald/
query/
4 lines
4 lines
mailinglists/
query/
2 lines
maniphest/
query/
2 lines
meta/
query/
2 lines
nuance/
query/
2 lines
2 lines
2 lines
2 lines
oauthserver/
query/
4 lines
2 lines
people/
query/
2 lines
2 lines
phid/
query/
2 lines
2 lines
phragment/
query/
2 lines
2 lines
2 lines
2 lines
policy/
__tests__/
2 lines
query/
2 lines
ponder/
query/
4 lines
2 lines
releeph/
query/
6 lines
6 lines
4 lines
repository/
query/
2 lines
2 lines
4 lines
2 lines
6 lines
2 lines
slowvote/
query/
4 lines
tokens/
query/
2 lines
2 lines

Diff 27315

View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...
View Options

src/applications/chatlog/query/PhabricatorChatLogQuery.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitMethodQuery.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

Loading...
View Options

src/applications/config/query/PhabricatorConfigEntryQuery.php

Loading...
View Options

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialChangesetQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialHunkQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockBlueprintQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockLogQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockResourceQuery.php

Loading...
View Options

src/applications/flag/query/PhabricatorFlagQuery.php

Loading...
View Options

src/applications/herald/query/HeraldRuleQuery.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptQuery.php

Loading...
View Options

src/applications/mailinglists/query/PhabricatorMailingListQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/meta/query/PhabricatorApplicationQuery.php

Loading...
View Options

src/applications/nuance/query/NuanceItemQuery.php

Loading...
View Options

src/applications/nuance/query/NuanceQueueQuery.php

Loading...
View Options

src/applications/nuance/query/NuanceRequestorQuery.php

Loading...
View Options

src/applications/nuance/query/NuanceSourceQuery.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/phid/query/PhabricatorHandleQuery.php

Loading...
View Options

src/applications/phid/query/PhabricatorObjectQuery.php

Loading...
View Options

src/applications/phragment/query/PhragmentFragmentQuery.php

Loading...
View Options

src/applications/phragment/query/PhragmentFragmentVersionQuery.php

Loading...
View Options

src/applications/phragment/query/PhragmentSnapshotChildQuery.php

Loading...
View Options

src/applications/phragment/query/PhragmentSnapshotQuery.php

Loading...
View Options

src/applications/policy/__tests__/PhabricatorPolicyAwareTestQuery.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/ponder/query/PonderAnswerQuery.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionQuery.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchQuery.php

Loading...
View Options

src/applications/releeph/query/ReleephProductQuery.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryMirrorQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/applications/tokens/query/PhabricatorTokenGivenQuery.php

Loading...
View Options

src/applications/tokens/query/PhabricatorTokenReceiverQuery.php

Loading...
Phabricator · Built by Phacility