Page MenuHomePhabricator
Differential D11368

Fix `AphrontTagView` visibility
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:46 AM.
Tags
None
Referenced Files
F13245577: D11368.diff
Thu, May 23, 6:06 AM
F13229382: D11368.id27301.diff
Mon, May 20, 4:09 PM
F13223650: D11368.diff
Sun, May 19, 4:46 AM
F13205673: D11368.diff
Wed, May 15, 2:16 AM
F13189666: D11368.diff
Sat, May 11, 6:17 AM
F13184999: D11368.id.diff
Sat, May 11, 2:22 AM
Unknown Object (File)
Tue, May 7, 10:02 AM
Unknown Object (File)
Fri, May 3, 10:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP843414379529: Fix `AphrontTagView` visibility
Summary

Ref T6822.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27301.Jan 13 2015, 11:46 AM
joshuaspence retitled this revision from to Fix `AphrontTagView` visibility.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:46 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 1:37 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2015, 1:37 PM
Closed by commit rP843414379529: Fix `AphrontTagView` visibility (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27311

View Options

src/applications/countdown/view/PhabricatorCountdownView.php

Loading...
View Options

src/applications/diviner/view/DivinerBookItemView.php

Loading...
View Options

src/applications/diviner/view/DivinerParameterTableView.php

Loading...
View Options

src/applications/diviner/view/DivinerReturnTableView.php

Loading...
View Options

src/applications/diviner/view/DivinerSectionView.php

Loading...
View Options

src/view/form/PHUIPagedFormView.php

Loading...
View Options

src/view/phui/PHUIBoxView.php

Loading...
View Options

src/view/phui/PHUIButtonBarView.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
View Options

src/view/phui/PHUIImageMaskView.php

Loading...
View Options

src/view/phui/PHUIListView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

src/view/phui/PHUIRemarkupPreviewPanel.php

Loading...
View Options

src/view/phui/PHUIStatusListView.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

src/view/phui/PHUITextView.php

Loading...
View Options

src/view/phui/PHUIWorkboardView.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarWidgetView.php

Loading...
Phabricator · Built by Phacility