Page MenuHomePhabricator
Differential D11366

Fix method visiblity for `PhabricatorFileTestCase::getPhabricatorTestCaseConfiguration`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 12:36 AM
Unknown Object (File)
Thu, Jan 23, 9:40 PM
Unknown Object (File)
Thu, Jan 23, 9:39 PM
Unknown Object (File)
Thu, Jan 23, 9:39 PM
Unknown Object (File)
Thu, Jan 23, 9:39 PM
Unknown Object (File)
Tue, Jan 21, 3:39 PM
Unknown Object (File)
Tue, Jan 21, 11:05 AM
Unknown Object (File)
Fri, Jan 17, 10:44 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP36b760cd8a13: Fix method visiblity for `PhabricatorFileTestCase…
Summary

Ref T6822.

Test Plan

grep for ->getPhabricatorTestCaseConfiguration(.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3811
Build 3823: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27299.Jan 13 2015, 11:35 AM
joshuaspence retitled this revision from to Fix method visiblity for `PhabricatorFileTestCase::getPhabricatorTestCaseConfiguration`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:35 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 1:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2015, 1:36 PM
Closed by commit rP36b760cd8a13: Fix method visiblity for `PhabricatorFileTestCase… (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
storage/
__tests__/
2 lines

Diff 27299

View Options

src/applications/files/storage/__tests__/PhabricatorFileTestCase.php

Loading...
Phabricator · Built by Phacility