Page MenuHomePhabricator
Differential D11355

T6895, Comment edit history should not provide action dropdown for transactions.
ClosedPublic
Actions

Authored by lpriestley on Jan 12 2015, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:25 PM
Unknown Object (File)
Sun, Apr 14, 4:41 AM
Unknown Object (File)
Sun, Apr 14, 4:41 AM
Unknown Object (File)
Sun, Apr 14, 4:36 AM
Unknown Object (File)
Sun, Apr 14, 4:12 AM
Unknown Object (File)
Fri, Apr 12, 1:55 PM
Unknown Object (File)
Thu, Apr 4, 4:02 PM
Unknown Object (File)
Mar 11 2024, 3:32 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6895: Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns
Commits
Restricted Diffusion Commit
rP98ec225c9c0f: T6895, Comment edit history should not provide action dropdown for transactions.
Summary

Fixes T6895, When viewing comment edit history, user should not see a dropdown for each comment edit transaction.

Test Plan

Edit task comment, view comment edit history, comment transactions should not provide a dropdown with action items.

Diff Detail

Repository
rP Phabricator
Branch
commenthistorydropdowns
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3797
Build 3809: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 27281.Jan 12 2015, 10:13 PM
lpriestley retitled this revision from to T6895, Comment edit history should not provide action dropdown for transactions..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T6895: Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 10:13 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 12 2015, 10:14 PM
epriestley edited edge metadata.

Looks great, thanks!

This revision is now accepted and ready to land.Jan 12 2015, 10:14 PM
Closed by commit rP98ec225c9c0f: T6895, Comment edit history should not provide action dropdown for transactions. (authored by lpriestley, committed by epriestley). · Explain WhyJan 12 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
controller/
3 lines
view/
13 lines
view/
phui/
12 lines

Diff 27281

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentHistoryController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility