Page MenuHomePhabricator

Don't pass `--quiet` to `csslint`
ClosedPublic

Authored by joshuaspence on Jan 10 2015, 7:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:22 PM
Unknown Object (File)
Nov 28 2024, 1:31 AM
Unknown Object (File)
Nov 21 2024, 3:13 AM
Unknown Object (File)
Nov 19 2024, 8:18 PM
Unknown Object (File)
Nov 16 2024, 12:06 PM
Unknown Object (File)
Nov 11 2024, 4:20 PM
Unknown Object (File)
Nov 8 2024, 2:09 PM
Unknown Object (File)
Nov 3 2024, 11:01 PM
Subscribers

Details

Summary

Similar to D11198. This flag doesn't do anything when combined with --format=lint-xml.

Test Plan
> csslint *.css
csslint *.css

csslint: There are 1 problems in /home/joshua/workspace/github.com/phacility/arcanist/fail.css.

fail.css
1: error at line 1, col 1
Unexpected token '~' at line 1, col 1.
~

csslint: No errors in /home/joshua/workspace/github.com/phacility/arcanist/pass.css.

> csslint --quiet *.css
csslint --quiet *.css

csslint: There are 1 problems in /home/joshua/workspace/github.com/phacility/arcanist/fail.css.

fail.css
1: error at line 1, col 1
Unexpected token '~' at line 1, col 1.
~

> csslint --format=lint-xml *.css
<?xml version="1.0" encoding="utf-8"?><lint>
<file name="/home/joshua/workspace/github.com/phacility/arcanist/fail.css"><issue line="1" char="1" severity="error" reason="Unexpected token '~' at line 1, col 1." evidence="~"/></file>
</lint>

> csslint --format=lint-xml --quiet *.css
<?xml version="1.0" encoding="utf-8"?><lint>
<file name="/home/joshua/workspace/github.com/phacility/arcanist/fail.css"><issue line="1" char="1" severity="error" reason="Unexpected token '~' at line 1, col 1." evidence="~"/></file>
</lint>

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3730
Build 3741: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
360 msArcanistXMLLinterTestCase::testLinter
403 msArcanistCSSLintLinterTestCase::testLinter
116 msArcanistCSSLintLinterTestCase::testVersion
193 msArcanistClosureLinterTestCase::testLinter
68 msArcanistClosureLinterTestCase::testVersion
View Full Test Results (1 Failed · 32 Passed · 14 Skipped)

Event Timeline

joshuaspence retitled this revision from to Don't pass `--quiet-` to `csslint`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence retitled this revision from Don't pass `--quiet-` to `csslint` to Don't pass `--quiet` to `csslint`.Jan 11 2015, 4:32 AM
joshuaspence edited edge metadata.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 5:39 PM
This revision was automatically updated to reflect the committed changes.