Page MenuHomePhabricator

Don't pass `--quiet` to `coffeelint`
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 9:48 AM.
Tags
None
Referenced Files
F13213626: D11198.diff
Fri, May 17, 7:57 AM
Unknown Object (File)
Tue, May 7, 7:37 AM
Unknown Object (File)
Fri, May 3, 7:03 AM
Unknown Object (File)
Sun, Apr 28, 1:28 AM
Unknown Object (File)
Thu, Apr 25, 1:25 AM
Unknown Object (File)
Apr 16 2024, 2:27 PM
Unknown Object (File)
Apr 11 2024, 5:34 AM
Unknown Object (File)
Apr 5 2024, 4:36 AM
Subscribers

Details

Summary

This flag doesn't do anything when combined with --reporter=checkstyle.

Test Plan
> coffeelint *.coffee
  ✗ fail.coffee
     ✗ #1: Class names should be camel cased. class name: boaConstrictor.
  ✓ pass.coffee

✗ Lint! » 1 error and 0 warnings in 2 files

> coffeelint --quiet *.coffee
  ✗ fail.coffee
     ✗ #1: Class names should be camel cased. class name: boaConstrictor.

✗ Lint! » 1 error and 0 warnings in 2 files

> coffeelint --reporter=checkstyle *.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="fail.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

> coffeelint --reporter=checkstyle --quiet *.coffee
<?xml version="1.0" encoding="utf-8"?>
<checkstyle version="4.3">
<file name="fail.coffee">
<error line="1"
    severity="error"
    message="Class names should be camel cased; context: class name: boaConstrictor"
    source="coffeelint"/>
</file>
</checkstyle>

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass `--quiet` to `coffeelint`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 4:35 PM
This revision was automatically updated to reflect the committed changes.