Page MenuHomePhabricator
Differential D11303

Maniphest - fix corner case where no-op subscriber change had wrong error
ClosedPublic
Actions

Authored by btrahan on Jan 9 2015, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 9:54 PM
Unknown Object (File)
Nov 20 2024, 4:06 PM
Unknown Object (File)
Nov 14 2024, 10:44 PM
Unknown Object (File)
Oct 21 2024, 3:14 PM
Unknown Object (File)
Oct 9 2024, 1:15 PM
Unknown Object (File)
Oct 9 2024, 1:15 PM
Unknown Object (File)
Oct 9 2024, 1:14 PM
Unknown Object (File)
Oct 9 2024, 1:05 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6732: error message when trying add a redundant CC is confusing
Commits
Restricted Diffusion Commit
rPef4f1a7f7473: Maniphest - fix corner case where no-op subscriber change had wrong error
Summary

Fixes T6732. Fix is to stop trying to catch the error in the controller and let the editor do its job.

Test Plan

tried to add an existing subscriber and got an error message about how that wouldn't do anything

Diff Detail

Repository
rP Phabricator
Branch
T6732
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3721
Build 3732: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27158.Jan 9 2015, 10:13 PM
btrahan added a task: T6732: error message when trying add a redundant CC is confusing.
btrahan retitled this revision from to Maniphest - fix corner case where no-op subscriber change had wrong error.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 9 2015, 10:13 PM
epriestley accepted this revision.Jan 9 2015, 10:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2015, 10:14 PM
Closed by commit rPef4f1a7f7473: Maniphest - fix corner case where no-op subscriber change had wrong error (authored by btrahan, committed by btrahan). · Explain WhyJan 9 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D11336: Fix some CC handling in Maniphest.Jan 11 2015, 11:56 PM
epriestley mentioned this in rP5b3b9b7182ae: Fix some CC handling in Maniphest.Jan 12 2015, 1:57 AM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
6 lines

Diff 27158

View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
Phabricator · Built by Phacility