Page MenuHomePhabricator
Create Task
Maniphest T6732

error message when trying add a redundant CC is confusing
Closed, ResolvedPublic
Actions

Description

  1. Create a ticket, cc yourself or someone else
  2. go down to the bottom and hit edit CC, add the same person again. Don't add a comment.
  3. The error message is "Empty Comment".

The problem isn't that the comment is empty (empty comments are fine when editing CCs) but that there was no CC change. This confused at least one user.

Revisions and Commits

rP Phabricator
D11303rPef4f1a7f7473 Maniphest - fix corner case where no-op subscriber change had wrong error

Event Timeline

cburroughs created this task.Dec 11 2014, 2:23 PM
cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a subscriber: cburroughs.
chad triaged this task as Low priority.Dec 11 2014, 4:34 PM
chad added a project: Transactions.
epriestley added a subscriber: epriestley.Dec 11 2014, 4:42 PM

I think this is because Maniphest still has an unusual / out-of-date pathway for transaction application. Most of the pathway is normal but some pieces in the middle (including this) are not yet.

btrahan claimed this task.Dec 25 2014, 12:14 AM
btrahan added a revision: D11303: Maniphest - fix corner case where no-op subscriber change had wrong error.Jan 9 2015, 10:13 PM
btrahan closed this task as Resolved by committing rPef4f1a7f7473: Maniphest - fix corner case where no-op subscriber change had wrong error.Jan 9 2015, 10:14 PM
btrahan added a commit: rPef4f1a7f7473: Maniphest - fix corner case where no-op subscriber change had wrong error.
Phabricator · Built by Phacility