Fix some CC handling in Maniphest
ClosedPublic
Actions

Authored by epriestley on Jan 11 2015, 11:56 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T6932: Unable to claim a Maniphest task

Commits

Restricted Diffusion Commit
rP5b3b9b7182ae: Fix some CC handling in Maniphest

Summary

Fixes T6932. Fixes some issues from D11303.

When claiming a task, if it was previously unassigned, we would try to CC null.
When claiming a task, if the current owner was already CC'd, the viewer would incorrectly be warned about all subscribers being CC'd.

Test Plan

Claimed an unclaimed task.
Claimed a task with owner CC'd.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27233.Jan 11 2015, 11:56 PM

epriestley retitled this revision from to Fix some CC handling in Maniphest.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 11 2015, 11:56 PM

Clean lint.

joshuaspence accepted this revision.Jan 12 2015, 12:17 AM

joshuaspence updated this object.

joshuaspence added a task: T6932: Unable to claim a Maniphest task.

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2015, 12:18 AM

btrahan awarded a token.Jan 12 2015, 1:50 AM

Closed by commit rP5b3b9b7182ae: Fix some CC handling in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2015, 1:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTransactionSaveController.php

34 lines

Diff 27235

View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Fix some CC handling in ManiphestClosedPublicActions