Various minor improvements to ArcanistPhpLinter.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC5492f0fad6c6: Minor improvements to `ArcanistPhpLinter`
arc unit
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 3661 Build 3671: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 257 ms | ArcanistPhpLinterTestCase::testLinter | |
| 445 ms | ArcanistCSSLintLinterTestCase::testLinter | |
| 136 ms | ArcanistCSSLintLinterTestCase::testVersion | |
| 187 ms | ArcanistClosureLinterTestCase::testLinter | |
| 54 ms | ArcanistClosureLinterTestCase::testVersion | |
| View Full Test Results (1 Failed · 32 Passed · 14 Skipped) |
Event Timeline
Comment Actions
FWIW, I do not get "PHP" in the output in 5.4.30:
epriestley@orbital ~/dev/phabricator $ php -v PHP 5.4.30 (cli) (built: Jul 29 2014 23:43:29) Copyright (c) 1997-2014 The PHP Group Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
epriestley@orbital ~/dev/phabricator $ php -l derp Parse error: parse error in derp on line 3 Errors parsing derp
Note "Parse error", not "PHP Parse error".
| src/lint/linter/ArcanistPhpLinter.php | ||
|---|---|---|
| 90 | Maybe phutil_utf8_strtolower(). | |