Page MenuHomePhabricator
Differential D11265

Minor improvements to `ArcanistPhpLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jan 7 2015, 9:29 AM.
Tags
None
Referenced Files
F13279576: D11265.diff
Sat, Jun 1, 8:40 PM
F13274380: D11265.diff
Fri, May 31, 3:38 AM
F13263063: D11265.id27095.diff
Mon, May 27, 6:57 AM
F13261645: D11265.diff
Mon, May 27, 1:17 AM
F13259361: D11265.diff
Sun, May 26, 7:48 PM
F13259194: D11265.id27094.diff
Sun, May 26, 5:40 PM
F13213250: D11265.diff
Fri, May 17, 7:33 AM
Unknown Object (File)
Tue, May 7, 5:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC5492f0fad6c6: Minor improvements to `ArcanistPhpLinter`
Summary

Various minor improvements to ArcanistPhpLinter.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3679
Build 3689: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27064.Jan 7 2015, 9:29 AM
joshuaspence retitled this revision from to Minor improvements to `ArcanistPhpLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 7 2015, 9:29 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Jan 7 2015, 12:54 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Jan 7 2015, 12:54 PM
epriestley requested changes to this revision.Jan 7 2015, 12:54 PM
epriestley edited edge metadata.

Oh, WIP + test failure.

This revision now requires changes to proceed.Jan 7 2015, 12:54 PM
epriestley added a comment.Jan 7 2015, 12:56 PM

FWIW, I do not get "PHP" in the output in 5.4.30:

epriestley@orbital ~/dev/phabricator $ php -v
PHP 5.4.30 (cli) (built: Jul 29 2014 23:43:29) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
epriestley@orbital ~/dev/phabricator $ php -l derp 

Parse error: parse error in derp on line 3
Errors parsing derp

Note "Parse error", not "PHP Parse error".

joshuaspence updated this revision to Diff 27090.Jan 8 2015, 8:31 AM
joshuaspence edited edge metadata.

Fix

Herald added a subscriber: Korvin. · View Herald TranscriptJan 8 2015, 8:31 AM
joshuaspence updated this revision to Diff 27091.Jan 8 2015, 8:34 AM
joshuaspence edited edge metadata.

s/php/PHP/

joshuaspence updated this revision to Diff 27092.Jan 8 2015, 8:36 AM

Don't allow linter severity to be customized

joshuaspence updated this object.Jan 8 2015, 8:37 AM
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Jan 8 2015, 8:38 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2015, 8:38 AM
epriestley added inline comments.Jan 8 2015, 8:38 AM
src/lint/linter/ArcanistPhpLinter.php
94

Maybe phutil_utf8_strtolower().

joshuaspence updated this revision to Diff 27094.Jan 8 2015, 8:39 AM
joshuaspence edited edge metadata.

Use getLintMessageName

Closed by commit rARC5492f0fad6c6: Minor improvements to `ArcanistPhpLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 8 2015, 8:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
57 lines

Diff 27091

View Options

src/lint/linter/ArcanistPhpLinter.php

Loading...
Phabricator · Built by Phacility