Page MenuHomePhabricator

Remove the noconfig flag
ClosedPublic

Authored by jjoos on Jan 6 2015, 12:58 PM.
Tags
None
Referenced Files
F14404551: D11250.diff
Mon, Dec 23, 5:28 AM
Unknown Object (File)
Fri, Dec 20, 5:09 PM
Unknown Object (File)
Fri, Dec 20, 3:43 PM
Unknown Object (File)
Sun, Dec 15, 11:21 AM
Unknown Object (File)
Tue, Dec 10, 9:59 AM
Unknown Object (File)
Sat, Dec 7, 5:26 PM
Unknown Object (File)
Fri, Dec 6, 6:44 AM
Unknown Object (File)
Wed, Dec 4, 5:04 PM
Subscribers
Tokens
"Like" token, awarded by tomdev.

Details

Summary

D11196 introduced a regression that made it impossible for coffeelint to read any configuration. I'm reverting the change in that diff.

Created a pull request changing the documentation of coffeelint to make sure I'm interpreting this flag correctly: https://github.com/clutchski/coffeelint/pull/364

Test Plan
  • patch
  • npm install -g coffeelint
  • create a test.coffee file with:
# 1234567890
  • arc lint test.coffee
OKAY  No lint warnings.
  • create a coffeelint.json with
{
  "max_line_length": {
    "value": 10
  }
}
  • arc lint test.coffee, expected output:
>>> Lint for test.coffee:

   Error  (COFFEE)
    Line exceeds maximum allowed length.

    >>>        1 # 1234567890
  • create a .arclint with
{
  "linters": {
    "coffeelint": {
      "type": "coffeelint",
      "coffeelint.config": "coffee_lint_config_with_different_name.json"
    }
  }
}
  • rename coffeelint.json to coffee_lint_config_with_different_name.json
  • arc lint test.coffee, expected output:
>>> Lint for test.coffee:

   Error  (COFFEE)
    Line exceeds maximum allowed length.

    >>>        1 # 1234567890

Diff Detail

Repository
rARC Arcanist
Branch
enable-coffee-linter-to-read-config
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3633
Build 3642: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

jjoos retitled this revision from to Remove the noconfig flag.
jjoos updated this object.
jjoos edited the test plan for this revision. (Show Details)
jjoos edited edge metadata.
jjoos edited the test plan for this revision. (Show Details)

It is confirmed that this was a bug in the coffeelint docs: https://github.com/clutchski/coffeelint/pull/364

This revision is now accepted and ready to land.Jan 6 2015, 2:59 PM
This revision was automatically updated to reflect the committed changes.