Page MenuHomePhabricator
Differential D11245

Fix method visibility for `LiskFixtureTestCase::getPhabricatorTestCaseConfiguration()`
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:49 AM.
Tags
None
Referenced Files
F14379524: D11245.diff
Sat, Dec 21, 2:58 AM
Unknown Object (File)
Thu, Dec 12, 9:31 PM
Unknown Object (File)
Sun, Dec 8, 10:07 PM
Unknown Object (File)
Sat, Dec 7, 4:48 PM
Unknown Object (File)
Fri, Dec 6, 1:39 PM
Unknown Object (File)
Thu, Dec 5, 12:38 PM
Unknown Object (File)
Thu, Dec 5, 4:02 AM
Unknown Object (File)
Thu, Dec 5, 3:26 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPade6f82dd578: Fix method visibility for `LiskFixtureTestCase…
Summary

Ref T6822.

Test Plan

Visual inspection. This method is only called from within the PhabricatorTestCase class.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3625
Build 3634: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26991.Jan 6 2015, 10:49 AM
joshuaspence retitled this revision from to Fix method visibility for `LiskFixtureTestCase::getPhabricatorTestCaseConfiguration()`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:49 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:25 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:48 PM
Closed by commit rPade6f82dd578: Fix method visibility for `LiskFixtureTestCase… (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
lisk/
__tests__/
2 lines

Diff 26991

View Options

src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php

Loading...
Phabricator · Built by Phacility