Page MenuHomePhabricator
Differential D11242

Fix method visibility for `PhabricatorApplicationSearchEngine` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:43 AM.
Tags
None
Referenced Files
F18105440: D11242.id27034.diff
Sun, Aug 10, 5:59 PM
F18102191: D11242.id26988.diff
Sat, Aug 9, 7:01 PM
F18099702: D11242.id.diff
Sat, Aug 9, 7:52 AM
F18097598: D11242.diff
Fri, Aug 8, 2:33 PM
Unknown Object (File)
Jun 21 2025, 1:12 PM
Unknown Object (File)
May 21 2025, 3:29 AM
Unknown Object (File)
May 10 2025, 4:12 AM
Unknown Object (File)
May 9 2025, 5:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPe448386d39a6: Fix method visibility for `PhabricatorApplicationSearchEngine` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the PhabricatorApplicationSearchEngine class.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3622
Build 3631: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26988.Jan 6 2015, 10:43 AM
joshuaspence retitled this revision from to Fix method visibility for `PhabricatorApplicationSearchEngine` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:43 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:27 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:49 PM
Closed by commit rPe448386d39a6: Fix method visibility for `PhabricatorApplicationSearchEngine` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
2 lines
2 lines
2 lines
audit/
query/
2 lines
calendar/
query/
4 lines
conduit/
query/
4 lines
countdown/
query/
4 lines
dashboard/
query/
4 lines
4 lines
differential/
query/
4 lines
diviner/
query/
4 lines
drydock/
query/
6 lines
4 lines
4 lines
4 lines
feed/
query/
2 lines
files/
query/
4 lines
flag/
query/
4 lines
fund/
query/
4 lines
4 lines
harbormaster/
query/
4 lines
4 lines
herald/
query/
4 lines
4 lines
legalpad/
query/
4 lines
4 lines
macro/
query/
4 lines
mailinglists/
query/
4 lines
maniphest/
query/
4 lines
meta/
query/
4 lines
notification/
query/
4 lines
oauthserver/
query/
4 lines
passphrase/
query/
4 lines
paste/
query/
2 lines
people/
query/
4 lines
4 lines
pholio/
query/
4 lines
phortune/
query/
2 lines
2 lines
2 lines
phrequent/
query/
4 lines
phriction/
query/
2 lines
ponder/
query/
4 lines
project/
query/
4 lines
releeph/
query/
2 lines
4 lines
2 lines
repository/
query/
4 lines
4 lines
search/
query/
4 lines
slowvote/
query/
4 lines

Diff 26988

View Options

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

Loading...
View Options

src/applications/almanac/query/AlmanacNetworkSearchEngine.php

Loading...
View Options

src/applications/almanac/query/AlmanacServiceSearchEngine.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockBlueprintSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockLogSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockResourceSearchEngine.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/flag/query/PhabricatorFlagSearchEngine.php

Loading...
View Options

src/applications/fund/query/FundBackerSearchEngine.php

Loading...
View Options

src/applications/fund/query/FundInitiativeSearchEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/mailinglists/query/PhabricatorMailingListSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/phortune/query/PhortuneCartSearchEngine.php

Loading...
View Options

src/applications/phortune/query/PhortuneChargeSearchEngine.php

Loading...
View Options

src/applications/phortune/query/PhortuneMerchantSearchEngine.php

Loading...
View Options

src/applications/phrequent/query/PhrequentSearchEngine.php

Loading...
View Options

src/applications/phriction/query/PhrictionSearchEngine.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
Phabricator · Built by Phacility