Page MenuHomePhabricator
Differential D11241

Fix method visibility for `PhabricatorController` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:37 AM.
Tags
None
Referenced Files
F14480354: D11241.id26987.diff
Sun, Dec 29, 7:48 PM
Unknown Object (File)
Fri, Dec 20, 11:16 PM
Unknown Object (File)
Tue, Dec 17, 1:51 PM
Unknown Object (File)
Mon, Dec 16, 9:05 PM
Unknown Object (File)
Sat, Dec 7, 1:41 PM
Unknown Object (File)
Thu, Dec 5, 4:02 AM
Unknown Object (File)
Thu, Dec 5, 3:27 AM
Unknown Object (File)
Wed, Dec 4, 6:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPe7f8e7974217: Fix method visibility for `PhabricatorController` subclasses
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within PhabricatorController subclasses.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3621
Build 3630: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26987.Jan 6 2015, 10:37 AM
joshuaspence retitled this revision from to Fix method visibility for `PhabricatorController` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:28 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:50 PM
Closed by commit rPe7f8e7974217: Fix method visibility for `PhabricatorController` subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
controller/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
audit/
controller/
2 lines
auth/
controller/
config/
2 lines
calendar/
controller/
4 lines
config/
controller/
2 lines
conpherence/
controller/
4 lines
countdown/
controller/
4 lines
dashboard/
controller/
2 lines
2 lines
2 lines
differential/
controller/
4 lines
diffusion/
controller/
2 lines
2 lines
drydock/
controller/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
files/
controller/
2 lines
fund/
controller/
2 lines
harbormaster/
controller/
2 lines
2 lines
2 lines
2 lines
herald/
controller/
4 lines
2 lines
legalpad/
controller/
2 lines
2 lines
2 lines
macro/
controller/
2 lines
mailinglists/
controller/
4 lines
meta/
controller/
2 lines
oauthserver/
controller/
client/
2 lines
owners/
controller/
2 lines
passphrase/
controller/
4 lines
paste/
controller/
4 lines
people/
controller/
4 lines
phame/
controller/
2 lines
pholio/
controller/
4 lines
phortune/
controller/
2 lines
2 lines
2 lines
2 lines
phriction/
controller/
4 lines
ponder/
controller/
2 lines
project/
controller/
4 lines
releeph/
controller/
2 lines
branch/
2 lines
product/
2 lines
2 lines
settings/
controller/
2 lines
slowvote/
controller/
4 lines
tokens/
controller/
5 lines

Diff 26987

View Options

src/applications/almanac/controller/AlmanacDeviceController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceListController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacNetworkController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacNetworkListController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacServiceController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacServiceListController.php

Loading...
View Options

src/applications/audit/controller/PhabricatorAuditController.php

Loading...
View Options

src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardListController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintController.php

Loading...
View Options

src/applications/drydock/controller/DrydockBlueprintListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockController.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseController.php

Loading...
View Options

src/applications/drydock/controller/DrydockLogController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileListController.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanListController.php

Loading...
View Options

src/applications/herald/controller/HeraldController.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptListController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentListController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroController.php

Loading...
View Options

src/applications/mailinglists/controller/PhabricatorMailingListsController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationsController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleController.php

Loading...
View Options

src/applications/phame/controller/PhameController.php

Loading...
View Options

src/applications/pholio/controller/PholioController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneCartListController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneChargeListController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantListController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionController.php

Loading...
View Options

src/applications/ponder/controller/PonderController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectListController.php

Loading...
View Options

src/applications/releeph/controller/ReleephController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductListController.php

Loading...
View Options

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...
View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteController.php

Loading...
View Options

src/applications/tokens/controller/PhabricatorTokenController.php

Loading...
Phabricator · Built by Phacility