Page MenuHomePhabricator
Differential D11240

Fix visibility of `AphrontBarView::getDefaultColor()` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:30 AM.
Tags
None
Referenced Files
F13358688: D11240.diff
Tue, Jun 25, 8:17 AM
F13328964: D11240.id27032.diff
Sun, Jun 16, 6:14 PM
F13328942: D11240.id26986.diff
Sun, Jun 16, 5:40 PM
F13321108: D11240.diff
Fri, Jun 14, 6:24 AM
F13308332: D11240.id27032.diff
Mon, Jun 10, 2:45 AM
F13305144: D11240.id.diff
Sat, Jun 8, 5:58 PM
F13300899: D11240.diff
Fri, Jun 7, 12:37 PM
F13286082: D11240.diff
Tue, Jun 4, 6:34 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP0715bce4a1b6: Fix visibility of `AphrontBarView::getDefaultColor()` methods
Summary

Ref T6822.

Test Plan

Visual inspection. This method is only called from within the AphrontBarView class.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3620
Build 3629: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26986.Jan 6 2015, 10:30 AM
joshuaspence retitled this revision from to Fix visibility of `AphrontBarView::getDefaultColor()` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:30 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:28 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:50 PM
Closed by commit rP0715bce4a1b6: Fix visibility of `AphrontBarView::getDefaultColor()` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
widget/
bars/
2 lines
2 lines

Diff 26986

View Options

src/view/widget/bars/AphrontGlyphBarView.php

Loading...
View Options

src/view/widget/bars/AphrontProgressBarView.php

Loading...
Phabricator · Built by Phacility