Page MenuHomePhabricator
Differential D11239

Fix visibility of the `ArcanistLintEngine::buildLinters()` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 12:24 AM
Unknown Object (File)
Fri, Nov 15, 10:45 AM
Unknown Object (File)
Mon, Nov 11, 5:08 AM
Unknown Object (File)
Wed, Nov 6, 4:39 PM
Unknown Object (File)
Thu, Oct 24, 11:01 PM
Unknown Object (File)
Oct 20 2024, 6:44 AM
Unknown Object (File)
Oct 19 2024, 2:09 PM
Unknown Object (File)
Oct 1 2024, 4:18 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
rARCcd591318ca65: Fix visibility of the `ArcanistLintEngine::buildLinters()` method
Summary

Ref T6822. This method needs to be public so that it can be called from ArcanistLintersWorkflow.

Test Plan

Ran arc linters.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3619
Build 3628: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26985.Jan 6 2015, 10:28 AM
joshuaspence retitled this revision from to Fix visibility of the `ArcanistLintEngine::buildLinters()` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:28 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:29 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:50 PM
Closed by commit rARCcd591318ca65: Fix visibility of the `ArcanistLintEngine::buildLinters()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
2 lines
2 lines

Diff 26985

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ArcanistUnitTestableLintEngine.php

Loading...
Phabricator · Built by Phacility