Paths

Table of Contentst

Differential D11236

Fix visibility of the `LinesOfALargeFile::readMore()` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:15 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

rPHU916e8545308a: Fix visibility of the `LinesOfALargeFile::readMore()` method

Summary

Ref T6822.

Test Plan

This only has one call site (in LinesOfALarge::next()).

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3616
Build 3625: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26982.Jan 6 2015, 10:15 AM

joshuaspence retitled this revision from to Fix visibility of the `LinesOfALargeFile::readMore()` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:15 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 6 2015, 2:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 2:44 PM

Closed by commit rPHU916e8545308a: Fix visibility of the `LinesOfALargeFile::readMore()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

filesystem/

linesofalarge/

LinesOfALargeFile.php

2 lines

Diff 26982

View Options

src/filesystem/linesofalarge/LinesOfALargeFile.php

Fix visibility of the `LinesOfALargeFile::readMore()` methodClosedPublicActions