Paths

Table of Contentst

Differential D11208

Export namespace in `ArcanistUnitTestResult` dictionary
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 11:57 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9e6f876a68b4: Export namespace in `ArcanistUnitTestResult` dictionary

Summary

D7952 added namespaces to ArcanistUnitTestResult but these are not exported and thus don't get sent from client to server.

Test Plan

Uploaded a diff and inspected the contents of the phabricator_differential.differential_diffproperty table.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3560
Build 3568: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26881.Jan 4 2015, 11:57 AM

joshuaspence retitled this revision from to Export namespace in `ArcanistUnitTestResult` dictionary.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 11:57 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D11209: Show unit test namespaces.Jan 4 2015, 12:01 PM

joshuaspence mentioned this in D11209: Show unit test namespaces.

epriestley accepted this revision.Jan 4 2015, 4:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2015, 4:41 PM

Closed by commit rARC9e6f876a68b4: Export namespace in `ArcanistUnitTestResult` dictionary (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

unit/

ArcanistUnitTestResult.php

1 line

workflow/

ArcanistDiffWorkflow.php

9 lines

Diff 26881

View Options

src/unit/ArcanistUnitTestResult.php