Ref T6852. Apparently, this is not a TODO.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T6852: Buttons break out of box when registering new users
- Commits
- Restricted Diffusion Commit
rP9a77c1636b0a: Remove a TODO comment
N/A
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3507 Build 3515: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/view/form/control/AphrontFormControl.php | ||
|---|---|---|
| 225 | You could also add $classes[] = 'grouped'; here, but some members of the team may frown on that. | |
Comment Actions
I think there may be a reason that "grouped" wasn't used here -- IIRC, it cuts off tokenizer dropdowns and the calendar date selection popup thing.
Comment Actions
Oh grouped doesn't hide overflow, it should have been fine. At least a quick test and those cases still work. I think grouped is just "clearfix" without older browser support if I recall (like IE6, IE7, IE Mac, etc).