Page MenuHomePhabricator

Add auth.querypublickeys to retrieve public keys
ClosedPublic

Authored by epriestley on Jan 2 2015, 11:40 PM.
Tags
None
Referenced Files
F13195971: D11163.diff
Sun, May 12, 10:48 PM
F13180346: D11163.diff
Wed, May 8, 11:21 PM
Unknown Object (File)
Sat, May 4, 7:06 PM
Unknown Object (File)
Wed, May 1, 5:05 AM
Unknown Object (File)
Wed, May 1, 12:36 AM
Unknown Object (File)
Fri, Apr 26, 4:35 PM
Unknown Object (File)
Fri, Apr 26, 4:35 PM
Unknown Object (File)
Fri, Apr 26, 4:35 PM
Subscribers

Details

Summary

Fixes T6484. I primarily need this to synchronize device public keys in the Phabricator cluster so the new stuff in T2783 works.

Although, actually, maybe I don't really need it. But I wrote it anyway and it's desirable to have sooner or later.

Test Plan

Ran method.

Diff Detail

Repository
rP Phabricator
Branch
sshquery
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3504
Build 3512: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add auth.querypublickeys to retrieve public keys.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php
70–72

This seems a little strange as opposed to just returning data?

This revision is now accepted and ready to land.Jan 5 2015, 4:40 PM
src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php
70–72

The more modern stuff is returning a result like:

array(
  'data' => <list of results>,
  'cursor' => <data for getting the next or previous page of results>,
)

...and then some other calls (like diffusion.querycommits) also return additional keys.

This makes it easier for callers to paginate results. Although they could usually have figured out the right before / after cursors for results where the cursor is just an ID, some cases like Maniphest queries with a nonstandard order-by have a complex cursor that clients can't trivially compute.

This revision was automatically updated to reflect the committed changes.